implement colorization for encoding.TextMarshaler#21
Merged
neilotoole merged 1 commit intoneilotoole:masterfrom Nov 10, 2023
hermannm:textmarshaler-colorization
Merged
implement colorization for encoding.TextMarshaler#21neilotoole merged 1 commit intoneilotoole:masterfrom hermannm:textmarshaler-colorization
neilotoole merged 1 commit intoneilotoole:masterfrom
hermannm:textmarshaler-colorization
Conversation
This was referenced Nov 8, 2023
Owner
|
@hermannm I pulled and tested this locally against a private project that uses Thank you for the quality of the PR btw! I'm going to use it as an example with my own team... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes (resolves #20)
TextMarshalerfield toColors, defaulting to the same color asStringTextMarshalercolor inencoder.encodeTextMarshalernullencoding inencodeTextMarshalerto use null color, like other encoder functionsfatihcolor.Colorswith newTextMarshalerfield to matchjsoncolor.ColorsTestEncode_TextMarshalerto confirm that the color is applied properlyI believe I've gone through every use of
Colorsand made sure that it accounts for the new field. All tests pass on my machine.One consideration in making
TextMarshalerdefault to the same color asStringis that this changes the behavior of the library: such values would previously have no color, but will now be colored as strings. However, I think this is more in line with the expected behavior, and since these are separate fields, users can still customize them separately as they wish.