Thanks to visit codestin.com
Credit goes to github.com

Skip to content

LstsqDrop can solve for all-zero weights #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

LstsqDrop can solve for all-zero weights #1607

merged 2 commits into from
May 4, 2020

Conversation

@hunse
Copy link
Contributor

@hunse hunse commented Apr 17, 2020 •
edited
Loading

Motivation and context:

Fixes #1541, where all-zero weights caused info1 to not be defined.
info1 has been replaced by info1s, a list of the info dicts
returned by the second solver.

Also made the wording changes (post_synapse -> pre_synapse) as per #1560.

How has this been tested?

Added a test based on the original issue.

How long should this take to review?

  • Quick (less than 40 lines changed or changes are straightforward)

Where should a reviewer start?

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the CONTRIBUTING.rst document.
  • I have updated the documentation accordingly.
  • I have included a changelog entry.
  • I have added tests to cover my changes.
  • I have run the test suite locally and all tests passed.

tbekolay
tbekolay reviewed Apr 17, 2020
View reviewed changes
@hunse hunse force-pushed the lstsqdrop-fix branch 2 times, most recently from e9e319e to ebf28bd Compare April 20, 2020 14:31
hunse added 2 commits May 4, 2020 10:30
@hunse @drasmuss
LstsqDrop can solve for all-zero weights
2b65ec5 
Fixes #1541, where all-zero weights caused `info1` to not be defined.
`info1` has been replaced by `info1s`, a list of the `info` dicts
returned by the second solver.
@hunse @drasmuss
Fix PES learning example to say pre_synapse
c5d82ab 
It previously mistakenly said "post_synapse". Fixes #1560.
@drasmuss drasmuss merged commit c5d82ab into master May 4, 2020
@drasmuss drasmuss deleted the lstsqdrop-fix branch May 4, 2020 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbekolay tbekolay tbekolay left review comments

@drasmuss drasmuss drasmuss approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LstsqDrop solver can sometimes raise UnboundLocalError

4 participants

@hunse @tbekolay @drasmuss