Added Repr Tests #1615
Merged
Added Repr Tests #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
f149005 to
65d2c5f
Compare
tbekolay
approved these changes
May 17, 2020
There was a problem hiding this comment.
This LGTM! I made a few nitpicky changes in d05b5b9, specifically:
- Putting the space on the first line of a string split into two lines
- Using floats in the Piecewise instances (the strings don't raise an error when instantiating the object, but they will give an error if you use them in a simulation)
- Removing the double
pytest.importorskipcalls (the more specific one,scipy.optimize, will cover both) - Instantiating some instances with keyword arguments rather than positional for readability
- Using lists instead of tuples in some places
I then made a new commit (65d2c5f) to simplify some of the repr generation code. In that old PR, we made it automatic, but in several of these classes we were still doing it manually. We wouldn't have noticed it without these repr tests!
I'll merge on Monday after talking to everyone about these changes.
hunse
reviewed
May 17, 2020
4 tasks
This commit also fixes a bug in FrozenObject.__repr__ for arguments that were being passed `Default`. previously they would always show up in the repr because the resolved default value is different from what shows up in the `defaults` dict, which will always be `nengo.Default`.
tbekolay
approved these changes
May 27, 2020
2709029 to
ada4393
Compare
Added tests for process, solver, transform, and learning rule reprs. Also consolidated all repr tests in the test_reprs.py file. This commit also makes some minor fixes associated with these tests: - PiecewiseDataParam was marked equatable and made hashable - Added __eq__ method for ChannelShape - Several unused test arguments were removed Co-authored-by: Trevor Bekolay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for processes, solvers, transforms, and learning rules. The reason this is a new PR is because the old one had bad names and descriptions that were throwing errors, and I couldn't seem to fix it.
Quick (less than 40 lines changed or changes are straightforward)
Non-code change (touches things like tests, documentation, build scripts)
I have read the CONTRIBUTING.rst document.
[na] I have updated the documentation accordingly.
[na] I have included a changelog entry.
[na] I have added tests to cover my changes.
I have run the test suite locally and all tests passed.