Experiment with Pytrees as samples #2111
Draft
+127
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the flattening/reshaping/batching of samples we need to know how many batch dims the samples have.
Since I can't figure out how to automatically increase that number for the output of a jax.lax.scan, instead here I keep around the number of non-batch dims and compute it from that.
That information is also present in hilbert, so in principle it would be possible to move all the tree maps etc from the wrapper class to netket, and support pytrees directly.
Example:
@gcarleo