Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix selectBox prompt + required + checkDefaultValue = False #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2025
Merged

Fix selectBox prompt + required + checkDefaultValue = False #343

merged 1 commit into from
Mar 31, 2025

Conversation

@bartko-s
Copy link
Contributor

  • bug fix
  • BC break? no

Example code:

$form->addSelect('country', 'Country', ['sk' => 'Slovakia', 'cz' => 'Czech Republic'])
    ->setRequired()	
    ->checkDefaultValue(false)
    ->setPrompt('-- select value --')
    ->setDefaultValue('en'); // value does not exists

The expected behavior is that the prompt will be selected but the first item is selected.
In version <= 3.2.1 this worked correctly.

@dg
Copy link
Member

dg commented Mar 31, 2025

Thanks

@dg dg merged commit d4dc7e8 into nette:master Mar 31, 2025
6 of 12 checks passed
dg pushed a commit that referenced this pull request Mar 31, 2025
@bartko-s @dg
SelectBox: correctly selects prompt [Closes #343]
de4ba5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartko-s @dg