Merged
Conversation
- g_file_get_device_number() - g_file_get_inode_num()
- Added g_strrchr() and g_strstr() - Made C prototypes for g_strchr() and g_strnchr() compatible with expected C library functions
metalefty
reviewed
Oct 26, 2021
| int | ||
| g_file_get_device_number(const char *filename) | ||
| { | ||
| #if defined(_WIN32) |
Member
There was a problem hiding this comment.
To be discussed in a separate issue, it might be time to discuss such Win32 hack is still needed.
As I already clarified Plat form Support Titer, Windows support is not maintained for years. I will raise a new discussion for this.
Member
|
It makes sense. Let's go ahead. |
metalefty
approved these changes
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2031
Before chansrv adds a UN*X file system path to the Windows clipboard, it checks that the file is not already remote (i.e. on a Windows filesystem).
There is no point in adding these files to the Windows clipboard as they are already on the remote system. Note that the files are in any case still added to the UN*X clipboard, so cut-paste functionality within the remote session works as expected.
Without this fix, selecting file in the remote filesystem and hitting CTRL-C hangs chansrv hard.
With the fix, it is possible to use the Unix desktop copy-paste functionality to copy files from the remote filesystem.