0.4 #34
Merged
0.4 #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes DECIMAL type with leading zeros in decimal fraction * Noticed that BLOB values return as String from ZongJi instead of as Buffer, like from node-mysql * Type test cases now allow greater payloads
* Previously, all blob types returned String values. node-mysql only provides String values for TEXT (MEDIUMTEXT, LONGTEXT...) data types while BLOB data types return Buffer. By checking the charset property of the column, TEXT values are decoded into String. * Breaking behavior change
* Values for affected columns will now show 'undefined' * Tested manually by commenting out a type case in Common.readMysqlValue
…red while trying to read the information_schema
Closed
Modelled after commits by @jmealo: jmealo@dc9d37d jmealo@1f219c3 jmealo@2422081
|
I was going to mention #27 but I saw it has been updated at https://github.com/nevill/zongji/blob/0.4/package.json So... thank you very much 👍 |
|
Yeaah, v0.4.0 is published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my proposal for the next release version of ZongJi.
Main new feature is JSON data type support! 3342916 (More details) I think I've come up with every necessary test case for the crazy
OPAQUEdata type. 👍I have bumped the version to 0.4.0 instead of 0.3.3 because of the breaking change regarding how blob types are now returned. 509cb6e Previously,
BLOB/TEXTtypes would always output String values. This behavior matchesnode-mysqlforTEXTtypes butBLOBvalues return Buffer. With this commit, the ZongJi behavior now matchesnode-mysql. Anybody depending onBLOBvalues to return String will from ZongJi will need to update their code to accept Buffer.There is also a bugfix for the
DECIMALdata type. Previously, values with leading zeros in the fractional decimal would have its leading zeros dropped. (e.g.123.000123became123.123) This has now been fixed.I have also included some commits from @jmealo's PR.
It would be nice to have automated tests for these commits 58fd776, aab7134, 30ce5c2 but I can't think of a way to do it without a test runner that creates MySQL accounts for each case to check permission failures.
Any comments? Am I missing anything?