Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Version 1.0.1 - Minor Updates on documentation and bug fix of version #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 22, 2022
Merged

Version 1.0.1 - Minor Updates on documentation and bug fix of version #31

merged 11 commits into from
Jun 22, 2022

Conversation

@DSchreyer
Copy link
Collaborator

This PR includes updates to README.md and fixes a bug of the version inside nextflow.config.

This should also create a Zenodo citation link, which was not generated after release 1.0.0.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/circdna branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 17, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 897c7e1

+| ✅ 142 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.0.1'
  • pipeline_todos - TODO string in README.md: Add citation for pipeline after first release. Uncomment lines below and update Zenodo doi and badge at the top of this file.
  • pipeline_todos - TODO string in WorkflowMain.groovy: Add Zenodo DOI for pipeline after first release

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-06-22 13:03:29

sguizard
sguizard approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@sguizard sguizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sguizard
sguizard approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@sguizard sguizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again

@DSchreyer DSchreyer requested a review from apeltzer June 22, 2022 11:27
@DSchreyer DSchreyer changed the title Dev1.0.1 - Minor Updates on documentation and bug fix of version Version 1.0.1 - Minor Updates on documentation and bug fix of version Jun 22, 2022
apeltzer
apeltzer approved these changes Jun 22, 2022
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - once released, we can add the Zenodo DOI to the readme directly on master.

@DSchreyer DSchreyer merged commit 50681ad into master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeltzer apeltzer apeltzer approved these changes

@sguizard sguizard sguizard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DSchreyer @apeltzer @sguizard