Thanks to visit codestin.com
Credit goes to github.com

Skip to content

uncomment required line for linting in --release mode #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Daniel-VM merged 2 commits into from
Nov 6, 2024
Merged

uncomment required line for linting in --release mode #182

Daniel-VM merged 2 commits into from
Nov 6, 2024

Conversation

@Daniel-VM
Copy link
Contributor

@Daniel-VM Daniel-VM commented Nov 5, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/bacass branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PR description

Uncomment line to pass nf-core linting test in --release mode.

Related (#181 )

@github-actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit e241ff8

+| ✅ 208 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-11-05 14:31:33

@Daniel-VM Daniel-VM marked this pull request as ready for review November 5, 2024 14:39
d4straub
d4straub approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Daniel-VM Daniel-VM merged commit c476f50 into nf-core:dev Nov 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4straub d4straub d4straub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Daniel-VM @d4straub