-
Notifications
You must be signed in to change notification settings - Fork 50
Pseudo PR - DO NOT MERGE #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates with latest boilerplate code from nf-core create
Dsl2 mash sketch
drpatelh
commented
May 28, 2021
Member
Author
drpatelh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing overall @aunderwo 😍 I have fixed/updated what I can in #38 so just a couple of things left to address that I can see and I think we are good to go.
Correct channel name
Pre-release fixes and syncing with latest DSL2 pipeline template
Collaborator
Member
Author
|
Great work all! Pipeline looks awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pseudo-PR for review of full pipeline prior to initial release, as described in https://nf-co.re/developers/adding_pipelines#core-pipeline-review
Do not merge - this PR just provides an interface to look over and comment on all pipeline code. Any suggestions can be applied to the
devbranch and this PR will automatically update. Once it has two community reviews, preferably one from someone in @nf-core/core , it can be closed and release 1.0 can go.