Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add LC_Extrap mode for @robert-davidson #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfy133 merged 3 commits into from
Aug 19, 2021
Merged

Add LC_Extrap mode for @robert-davidson #780

jfy133 merged 3 commits into from
Aug 19, 2021

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Jul 26, 2021

To close #769

Note linting fail is because the nf-core lint CI doesn't match template as I have to specify the older DSL1 version.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 requested a review from a team July 26, 2021 08:01
@jfy133 jfy133 linked an issue Jul 26, 2021 that may be closed by this pull request
Addition of preseq's lc_extrap function #769
Closed
@jfy133 jfy133 merged commit b057f0a into major-release-wangen Aug 19, 2021
@jfy133 jfy133 deleted the preseq-extension branch August 19, 2021 06:41
@github-actions
Copy link

github-actions bot commented Aug 19, 2021

YAML linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install yaml-lint
  • Fix the markdown errors
    • Run the test locally: yamllint $(find . -type f -name "*.yml" -o -name "*.yaml")
    • Fix any reported errors in your YAML files

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeltzer apeltzer apeltzer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Addition of preseq's lc_extrap function

3 participants

@jfy133 @apeltzer