Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test tsv to test #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfy133 merged 1 commit into from
Sep 14, 2021
Merged

Test tsv to test #795

jfy133 merged 1 commit into from
Sep 14, 2021

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Sep 14, 2021 •
edited
Loading

To close #794

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 14, 2021

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @jfy133,

It looks like this pull-request is has been made against the nf-core/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the nf-core/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@jfy133 jfy133 requested review from a team and drpatelh September 14, 2021 13:25
@jfy133 jfy133 changed the base branch from master to dev September 14, 2021 13:25
drpatelh
drpatelh approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks!

mahesh-panchal
mahesh-panchal approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me (but I may not be aware of all the guidelines).

@jfy133 jfy133 merged commit 2ccf4a3 into dev Sep 14, 2021
@jfy133 jfy133 deleted the test_tsv-to-test branch September 15, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeltzer apeltzer apeltzer approved these changes

@mahesh-panchal mahesh-panchal mahesh-panchal approved these changes

@drpatelh drpatelh drpatelh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch -profile test_tsv -> -profile test

5 participants

@jfy133 @apeltzer @mahesh-panchal @drpatelh