Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix post-ar trimming not being included in downstream analyses #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jfy133 merged 9 commits into from
Jan 13, 2022
Merged

Fix post-ar trimming not being included in downstream analyses #823

jfy133 merged 9 commits into from
Jan 13, 2022

Conversation

@jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 11, 2022 •
edited
Loading

I accidently left debugging code rather than mixxing the trimmed files back into the input channel for lane merging 🤦‍♀

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

To cloe #822

TCLamnidis
TCLamnidis approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@TCLamnidis TCLamnidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfy133
Copy link
Member Author

jfy133 commented Jan 12, 2022

Will wait for CI tests then merge 👍

@jfy133 jfy133 merged commit c417efc into dev Jan 13, 2022
@jfy133 jfy133 deleted the fix-artrimming branch January 13, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TCLamnidis TCLamnidis TCLamnidis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jfy133 @TCLamnidis