Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@TCLamnidis
Copy link
Collaborator

@TCLamnidis TCLamnidis commented Mar 18, 2022

The most recent version of pileupcaller removes the .txt suffix that previous versions added to the genotype files.

eigenstrat_snp_coverage.py could not find the input files because it expected these suffixes to be present. With these changes, the script will no longer expect a .txt suffix to its input files.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • CHANGELOG.md is updated.

@github-actions
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@jfy133 jfy133 self-requested a review March 18, 2022 07:39
@jfy133
Copy link
Member

jfy133 commented Mar 18, 2022

@TCLamnidis can wait for CI tests to pass then you can merge :)

@apeltzer apeltzer merged commit ef683d0 into dev Mar 18, 2022
@apeltzer apeltzer deleted the pileupcaller_fix branch March 18, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants