Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Lehmann-Fabian
Copy link
Member

Signed-off-by: Lehmann_Fabian [email protected]

Cannot start DSL1 workflows with the newest Nextflow version. So I had to define the DSL version explicitly.

PR checklist

  • [ x] This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 self-requested a review April 26, 2022 06:21
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Lehmann-Fabian ! I'm just going to do a quick local test what happens when you run this but with earlier versions of NXF and then merge

@jfy133
Copy link
Member

jfy133 commented Apr 26, 2022

Ah, please update changelog then we are good to go - works OK on my tests! :)

@Lehmann-Fabian
Copy link
Member Author

Thanks a lot for your review. I updated the changelog accordingly.

@jfy133 jfy133 merged commit 98a9545 into nf-core:dev Apr 26, 2022
@github-actions
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@github-actions
Copy link

YAML linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install yaml-lint
  • Fix the markdown errors
    • Run the test locally: yamllint $(find . -type f -name "*.yml" -o -name "*.yaml")
    • Fix any reported errors in your YAML files

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

@jfy133 jfy133 mentioned this pull request Apr 26, 2022
@jfy133 jfy133 linked an issue Apr 26, 2022 that may be closed by this pull request
@jfy133 jfy133 mentioned this pull request Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nextflow.enable.dsl = 1

2 participants