-
Notifications
You must be signed in to change notification settings - Fork 86
Define DSL1 explicitly, as Nextflow made DSL2 default #882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lehmann_Fabian <[email protected]>
jfy133
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Lehmann-Fabian ! I'm just going to do a quick local test what happens when you run this but with earlier versions of NXF and then merge
|
Ah, please update changelog then we are good to go - works OK on my tests! :) |
Signed-off-by: Lehmann_Fabian <[email protected]>
|
Thanks a lot for your review. I updated the changelog accordingly. |
Markdown linting is failingTo keep the code consistent with lots of contributors, we run automated code consistency checks.
Once you push these changes the test should pass, and you can hide this comment 👍 We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help! Thanks again for your contribution! |
YAML linting is failingTo keep the code consistent with lots of contributors, we run automated code consistency checks.
Once you push these changes the test should pass, and you can hide this comment 👍 We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help! Thanks again for your contribution! |
Signed-off-by: Lehmann_Fabian [email protected]
Cannot start DSL1 workflows with the newest Nextflow version. So I had to define the DSL version explicitly.
PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).