-
Notifications
You must be signed in to change notification settings - Fork 86
Endorspy resume fix #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endorspy resume fix #902
Conversation
This PR is against the
|
Markdown linting is failingTo keep the code consistent with lots of contributors, we run automated code consistency checks.
Once you push these changes the test should pass, and you can hide this comment 👍 We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help! Thanks again for your contribution! |
YAML linting is failingTo keep the code consistent with lots of contributors, we run automated code consistency checks.
Once you push these changes the test should pass, and you can hide this comment 👍 We highly recommend setting up yaml-lint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help! Thanks again for your contribution! |
|
Please also test @TCLamnidis in addition to the review |
TCLamnidis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Currently testing
|
Tests passed. All good <3 |
|
Closes #733
Main changes: replaces lane with
0after lane fastq merging, and pulls single string for seqtype ; both to remove (unstable) NXF arraybag objects beforejoinAlso includes: removal of old debugging dumps
Alternatively, to reduce possible downstream effects (and keep behaviour from previous versions), we could just do the flatten() or even remove via a
.map()the two problematic meta fields from the two endorspy input channels...PR checklist
scrape_software_versions.pynf-core lint .).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).