Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jzohren
Copy link
Contributor

@jzohren jzohren commented Apr 2, 2023

PR checklist

  • [x ] This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/hic branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • [x ] Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nservant and others added 2 commits January 21, 2023 12:40
fixed a few spelling mistakes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I will leave it to the main devs to verify accuracy :)

results of the whole pipeline
- [Export](#exprot) - additionnal export for compatibility with downstream
analysis tool and visualization
analysis tool and visualisation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‡¬πŸ‡§ πŸ‡¬πŸ‡§ πŸ‡¬πŸ‡§ πŸ‡¬πŸ‡§

@nservant nservant self-requested a review April 26, 2023 11:35
Copy link
Collaborator

@nservant nservant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good ! thanks

@nservant nservant merged commit 1cc0a18 into nf-core:dev Apr 26, 2023
@github-actions
Copy link

Python linting (black) is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install black: pip install black
  • Fix formatting errors in your pipeline: black .

Once you push these changes the test should pass, and you can hide this comment πŸ‘

We highly recommend setting up Black in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants