Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Release 1.1.3 - Blue Grouse #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sguizard merged 10 commits into from
Mar 9, 2023
Merged

Release 1.1.3 - Blue Grouse #13

sguizard merged 10 commits into from
Mar 9, 2023

Conversation

@sguizard
Copy link
Collaborator

@sguizard sguizard commented Mar 9, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Mar 9, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1315e12

+| ✅ 156 tests passed       |+
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '1.1.3'
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-03-09 09:00:59

maxulysse
maxulysse reviewed Mar 9, 2023
View reviewed changes
maxulysse
maxulysse approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@DSchreyer DSchreyer self-requested a review March 9, 2023 08:55
maxulysse
maxulysse approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3<3<3

jasmezz
jasmezz approved these changes Mar 9, 2023
View reviewed changes
Copy link

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be a bit more descriptive in the changelog, either link the PR number for each entry or give the specific file that was updated (e.g. - Fix pipeline image path docs/images/Isoseq_pipeline_V2.1-metro_clean.png). Maybe that is just a personal taste.
And you don't mention updated modules – I would do that as well.
Otherwise LGTM once checks pass!

@sguizard
Copy link
Collaborator Author

sguizard commented Mar 9, 2023 •
edited
Loading

I note your remark for next commits, I'll try to be more descriptive.
For modules, the updates were on the meta files.
The programs versions didn't changed. That why I didn't added a table like in the previous release.

Many thanks for your reviews.

@sguizard sguizard merged commit 26153d7 into master Mar 9, 2023
DSchreyer
DSchreyer approved these changes Mar 9, 2023
View reviewed changes
Copy link

@DSchreyer DSchreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good to me! Nothing to complain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

@DSchreyer DSchreyer DSchreyer approved these changes

@jasmezz jasmezz jasmezz approved these changes

Assignees

@maxulysse maxulysse

@DSchreyer DSchreyer

@jasmezz jasmezz

Labels

None yet

Projects

PRs to master
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sguizard @maxulysse @DSchreyer @jasmezz