Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Updating Readme #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
varunshamanna wants to merge 0 commits into from
Closed

Updating Readme #1399

varunshamanna wants to merge 0 commits into from

Conversation

@varunshamanna
Copy link

@varunshamanna varunshamanna commented Mar 17, 2022 •
edited
Loading

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@drpatelh drpatelh mentioned this pull request Mar 17, 2022
Closed
@varunshamanna
Copy link
Author

varunshamanna commented Mar 17, 2022

I have Updated the Readme for each command and aligned the lines equally.

@edmundmiller edmundmiller self-requested a review March 19, 2022 15:11
edmundmiller
edmundmiller approved these changes Mar 19, 2022
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I think we're going to cut 2.4 pretty soon though, so we shouldn't close #1400 yet.

@muffato
Copy link
Member

muffato commented Sep 28, 2022

@varunshamanna . Would you be able to update the README for the latest version (2.5.1) of nf-core tools ?

@varunshamanna
Copy link
Author

varunshamanna commented Sep 28, 2022 via email

@muffato
Copy link
Member

muffato commented Sep 28, 2022

Absolutely fine 👍 . Thank you very much !

@matthdsm matthdsm added the stale Stale label Mar 6, 2023
@matthdsm
Copy link
Contributor

matthdsm commented Mar 6, 2023

Hi there!

We've noticed there hasn't been much activity here. Are you still planning on working on this?
If not, you can ignore this message and we'll close your PR in about 2 weeks

Cheers
the nf-core maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edmundmiller edmundmiller edmundmiller approved these changes

Assignees

No one assigned

Labels

stale Stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@varunshamanna @muffato @matthdsm @edmundmiller