Fix BCL Convert Container Name #3785
Conversation
There is a typo in the container name for the BCL Convert Process module. It should be `nfcore/bclconvert:4.0.3` instead of `nf-core/bclconvert:4.0.3`. Notice the additional dash. https://github.com/nf-core/modules/blob/master/modules/nf-core/bclconvert/Dockerfile#L2 As a result, the following error occurs ... > docker: Error response from daemon: pull access denied for nf-core/bclconvert, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.
There was a problem hiding this comment.
Appreciate the catch! However, this is using the quay image(quay.io/nf-core/bclconvert) which has the dash
https://quay.io/repository/nf-core/bclconvert
If you would like to PR a fix to the docker file comment
|
Ok @emiller88, So the module doesn't work currently. This PR fixed the problem for me. If this change is not correct then, what changes should we make or what am I doing wrong on my end? |
|
Also $ docker pull quay.io/nf-core/bclconvert |
|
Could you elaborate on how it doesn't work? And try $ docker pull quay.io/nf-core/bclconvert:4.0.3It doesn't seem like there's a latest tag for the quay repo. |
|
Yeah I forgot the tag when I tried to pull the image. Thanks. It doesn't work because the container definition in the module does not point to Should it not point to |
No, sadly it's a whole thing 🫠 modules/tests/config/nextflow.config Lines 32 to 34 in 90038ef Then you can point at the biocontainers on ECR so you don't hit rate limits and whatnot https://aws.amazon.com/blogs/hpc/biocontainers-are-now-available-in-amazon-ecr-public-gallery/ For context, they announced it last year, and then the |
|
Oh I see thanks! I'll close this guy too then since it sounds like we just need to add |
There is a typo in the container name for the BCL Convert Process module. It should be
nfcore/bclconvert:4.0.3instead ofnf-core/bclconvert:4.0.3. Notice the additional dash.https://github.com/nf-core/modules/blob/master/modules/nf-core/bclconvert/Dockerfile#L2
As a result, the following error occurs ...
This change fixes the name of the container.