Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sofstam
Copy link
Contributor

@sofstam sofstam commented Sep 27, 2024

This PR adds nf-test to motus/merge module

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@sofstam sofstam requested a review from jfy133 as a code owner September 27, 2024 07:39
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the commented out stub test

@sofstam sofstam marked this pull request as draft September 27, 2024 08:47
@sofstam sofstam marked this pull request as ready for review October 2, 2024 08:59
@sofstam sofstam requested review from a team and LeuThrAsp and removed request for a team October 2, 2024 15:41
@sofstam sofstam added this pull request to the merge queue Oct 3, 2024
Merged via the queue into nf-core:master with commit 3cf419b Oct 3, 2024
12 checks passed
@sofstam sofstam deleted the update_motus branch October 3, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants