-
Notifications
You must be signed in to change notification settings - Fork 146
Longread only functionality #718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
96 commits
Select commit
Hold shift + click to select a range
5ffb327
Add longread only test config
muabnezor 695da2b
Change samplesheet validation schema to allow for longread-only sampl…
muabnezor f67b6b3
Check if both short, and long reads are given
muabnezor bb78aab
fix validation schema for samplesheet
muabnezor 992b01e
Merge remote-tracking branch 'upstream/dev' into longread_only
muabnezor bfd404c
Add separate wubworkflow for longread host removal
muabnezor 387284d
Add longread meta-assemblers metaflye and metamdbg
muabnezor 6948316
Add longread assemble config
muabnezor 762f12b
Prepare binning for longread assemblies
muabnezor c7a5cdf
Fix config and how long reads are prepared for binning
muabnezor 18ae00d
change jgi_summarize_bam_contig_depths --percentidentity default from…
muabnezor 8a22939
Fix longread binning preparation from all combination of assemblies, …
muabnezor 038a87b
format
muabnezor 3ff8de2
Fix longread hostremoval, and fix --longread_percentidentiy parameter…
muabnezor e277290
Add test_longread to profiles, and ci testing
muabnezor 75a36f2
Fix validation schema, and fix assembly channels for longread and sho…
muabnezor 67d44d0
Change logic in samplesheet validation, ch_raw_short_reads should be …
muabnezor ca4d101
fix custom samtools view module
muabnezor cfd43e7
Merge branch 'dev' into longread_only
muabnezor 6765ab1
Make sure filtlong works without short reads. the join operator shoul…
muabnezor e73975c
Make sure FILTLONG is not run when there are no long reads
muabnezor 686fafe
Fix grouping logic for channels in longreads_binning_preparation subw…
muabnezor a0279fe
make assembly into subworkflow
muabnezor 28f72af
Fix long read assembly input
muabnezor 1c4b364
Update docs
muabnezor 34067db
Update citations for tools
muabnezor 26a0fe7
Fix versions channel in subworkflows
muabnezor d9564da
Fix bug when running with --keep_phix, make ch_phix_db_file empty Cha…
muabnezor 9087f2f
Merge branch 'dev' into longread_only
muabnezor ba0f831
fix modules.config
muabnezor d46aa6d
Fix linting
muabnezor f90e5f5
Use nf-core official module for samtools fastq
muabnezor 85c2e82
Change modules config
muabnezor 7398ba3
change hybrid logic
muabnezor ae1953d
fix samplesheet validation
muabnezor d95b501
Apply suggestions from code review
muabnezor 855a299
Merge branch 'dev' into longread_only
muabnezor 095b6fb
changes from review
muabnezor 00105b2
fix linting
muabnezor 6ca7617
Fix how assemblies are grouped with aligned reads in longread pre bin…
muabnezor c074c72
make local module of samtools for longread host removal
muabnezor 0b632f1
make METABAT_JGISUMMARIZEBAMCONTIGS run separately for longreads and …
muabnezor 7464ac5
add shortread_percentidentity parameter
muabnezor ff1ef2b
fix depth output from binning subworkflow
muabnezor e281a4a
fix samtools_unmapped output name
muabnezor 681320d
update metamdbg/asm
muabnezor ab441e1
add parameters for configuring minimap index making
muabnezor abefb5f
Fix usage docs
muabnezor 39fb828
Add sequencing platform check for samples within a group
muabnezor daacdaa
Fix platform checks
muabnezor 873dc16
fix error messages
muabnezor 635d98c
Fix error messages
muabnezor 2490d3e
resolve conflicts with dev
muabnezor e3485c8
fix
muabnezor 8d5e766
fix shortread percentidentity when running JGISUMMARIZEBAMCONTIGDEPTHS
muabnezor f7b7699
Merge branch 'dev' into longread_only
jfy133 6dc329c
Add run merging for long reads
muabnezor 3bdb585
Set minimap2, flye and metaMDBG options based on longread platform
muabnezor b377c31
Merge branch 'dev' into longread_only
muabnezor d70ee07
fix modules.json
muabnezor c3d5eef
Fix when running with longreads with param --skip_adapter_trimming
muabnezor 21df3d8
Fix running binrefinement with longreads
muabnezor 08b35a5
Enforce Sequencing platforms in the samplesheet
muabnezor 3e64400
Added documentation, and use new v4 samplesheets for tests
muabnezor dc11fac
add skip_longread_filtering, to skip filtering of long reads
muabnezor 7b2d65b
Update CHANGELOG.md
jfy133 e345fce
Update CHANGELOG.md
jfy133 239dc6c
Update CHANGELOG.md
jfy133 8cf9e03
Merge remote-tracking branch 'upstream/dev' into longread_only
jfy133 08aa617
Fix running chopper with --keep_lambda. making sure to pass on an emp…
muabnezor 4373b35
Don't build host genome with bowtie if short reads channel is empty
muabnezor a0124dc
Merge branch 'dev' into longread_only
jfy133 ea3b1d2
Enable hybrid assembly with spades when running with pacbio longreads
muabnezor e1b2ba7
Merge remote-tracking branch 'origin/longread_only' into longread_only
muabnezor f946419
Set resources for longread assemblers
muabnezor e1ffcb6
Pass on meta.lr_platform when pooling long reads
muabnezor 39d57b5
Merge branch 'dev' into longread_only
jfy133 e6d23ec
Fix problem in run merging for long reads
muabnezor 9b7fda2
Don't pool long reads for spades, if no short reads are given
muabnezor 9272bd0
Merge remote-tracking branch 'origin/longread_only' into longread_only
muabnezor ce95f1c
remove custom maxRetries for flye and metaMDBG
muabnezor 1f4eb9c
Split PACBIO longread platform into PACBIO_CLR and PACBIO_HIFI, set d…
muabnezor 14d985f
Apply suggestions from code review
muabnezor c7fef5a
Suggested fixes from review
muabnezor 3126a61
Merge branch 'dev' into longread_only
muabnezor ae4465b
remove error messages for read platforms in the input schema
muabnezor 5be0223
Merge remote-tracking branch 'origin/longread_only' into longread_only
muabnezor f755881
remove unused samtools nf-core modules
muabnezor 64fc954
add my orcid
muabnezor 644287b
fix linting
muabnezor 4735db3
adapt samtools faidx call in ancient dna workflow to account for the …
muabnezor 0fed848
Merge branch 'dev' into longread_only
jfy133 20e1630
[automated] Fix code linting
nf-core-bot 3ba6414
Merge branch 'dev' into longread_only
jfy133 294dbbf
Merge branch 'dev' into longread_only
jfy133 10d519f
Fix bin summary by ensuring depth channel dont have binner field in meta
muabnezor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| repos: | ||
| - repo: https://github.com/pre-commit/mirrors-prettier | ||
| rev: "v3.1.0" | ||
| rev: "v4.0.0-alpha.8" | ||
| hooks: | ||
| - id: prettier | ||
| additional_dependencies: | ||
| - [email protected] | ||
|
|
||
| - repo: https://github.com/editorconfig-checker/editorconfig-checker.python | ||
| rev: "3.1.2" | ||
| rev: "3.2.1" | ||
| hooks: | ||
| - id: editorconfig-checker | ||
| alias: ec |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should limit to just Illumina as I guess for the others we wouldn't want the data to go through read clipping etc?
Although maybe if we have the 'skip steps' that @erikrikarddaniel is suggesting maybe it's fine and we document it?
What do you think @nf-core/mag team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a future PR could branch on the meta.reads_platform value and feed reads in only if they match a tool’s expectation. But for now I think non-Illumina is rare enough that we should expect people who have it to know?