Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Comments

Remove taxonomic profiling from pipeline#825

Merged
jfy133 merged 6 commits intonf-core:devfrom
dialvarezs:remove-taxprofiling
Jun 11, 2025
Merged

Remove taxonomic profiling from pipeline#825
jfy133 merged 6 commits intonf-core:devfrom
dialvarezs:remove-taxprofiling

Conversation

@dialvarezs
Copy link
Member

@dialvarezs dialvarezs commented Jun 10, 2025

Closes #824

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.2.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@dialvarezs
Copy link
Member Author

@nf-core-bot fix linting

@dialvarezs dialvarezs changed the title Remove kraken2, centrifuge and krona usage and references Remove taxonomic profiling from pipeline Jun 10, 2025
@dialvarezs dialvarezs linked an issue Jun 10, 2025 that may be closed by this pull request
@dialvarezs dialvarezs marked this pull request as ready for review June 10, 2025 11:35
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me @dialvarezs !

I will update the workflow diagrams before release in one go

@jfy133
Copy link
Member

jfy133 commented Jun 11, 2025

I'm going to merge this in on your behalf (sorry @dialvarezs hope that's OK!) as I need it for generating the new nf-test snapshots in teh template :)

@jfy133 jfy133 merged commit f91c729 into nf-core:dev Jun 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove taxonomic profiling functionality

3 participants