Conversation
…o speed up run time
|
Member
Author
|
@nf-core-bot fix linting |
JoseEspinosa
approved these changes
Jun 18, 2025
Member
JoseEspinosa
left a comment
There was a problem hiding this comment.
LGTM! Just some small suggestions but only formatting issues and a possible tyop, so feel free to merge once you go throw them
Comment on lines
+16
to
+18
| // // stable_name: All files + folders in ${params.outdir}/ with a stable name | ||
| // def stable_name = getAllFilesFromDir(params.outdir, relative: true, includeDir: true, ignore: ['pipeline_info/*.{html,json,txt}']) | ||
| // // stable_path: All files in ${params.outdir}/ with stable content |
Member
There was a problem hiding this comment.
Suggested change
| // // stable_name: All files + folders in ${params.outdir}/ with a stable name | |
| // def stable_name = getAllFilesFromDir(params.outdir, relative: true, includeDir: true, ignore: ['pipeline_info/*.{html,json,txt}']) | |
| // // stable_path: All files in ${params.outdir}/ with stable content | |
| // stable_name: All files + folders in ${params.outdir}/ with a stable name | |
| // def stable_name = getAllFilesFromDir(params.outdir, relative: true, includeDir: true, ignore: ['pipeline_info/*.{html,json,txt}']) | |
| // stable_path: All files in ${params.outdir}/ with stable content |
Comment on lines
+27
to
+30
| // // All stable path name, with a relative path | ||
| // stable_name, | ||
| // // All files with stable contents | ||
| // stable_path |
Member
There was a problem hiding this comment.
Suggested change
| // // All stable path name, with a relative path | |
| // stable_name, | |
| // // All files with stable contents | |
| // stable_path | |
| // All stable path name, with a relative path | |
| // stable_name, | |
| // All files with stable contents | |
| // stable_path |
| mode: params.publish_dir_mode, | ||
| pattern: "*.{bam,bai}", | ||
| enabled: params.save_assembly_mapped_reads | ||
| enabled: params.save_assembly_mapped_reads, |
Member
There was a problem hiding this comment.
Is the comma here needed?
Suggested change
| enabled: params.save_assembly_mapped_reads, | |
| enabled: params.save_assembly_mapped_reads |
Member
There was a problem hiding this comment.
I asked on slack and seems that the nxf server likes it, I don't... 😄
Member
Author
|
I'm going to rudely ignore the suggestions and go blindly with the approval 😆 Context:
But I appreciate the ✔️ ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).