Template update3.1.1 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 17, 2025 12:47
|
erikrikarddaniel
approved these changes
Jan 20, 2025
Member
erikrikarddaniel
left a comment
There was a problem hiding this comment.
Three questions/things to fix, then fine!
CITATIONS.md
Outdated
| - [FastQC](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/) | ||
|
|
||
| > Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online]. | ||
| > Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online].- [MultiQC](https://pubmed.ncbi.nlm.nih.gov/27312411/) |
Member
There was a problem hiding this comment.
This doesn't look correct. Why is the [MultiQC] part there?
nextflow.config
Outdated
| includeConfig !System.getenv('NXF_OFFLINE') && params.custom_config_base ? "${params.custom_config_base}/nfcore_custom.config" : "/dev/null" | ||
|
|
||
| // Load nf-core/magmap custom profiles from different institutions. | ||
| // TODO nf-core: Optionally, you can add a pipeline-specific nf-core config at https://github.com/nf-core/configs |
Member
There was a problem hiding this comment.
Remaining TODO. Won't lint. I think this line (and the next) can be deleted as we don't have any pipeline-specific institute profile (yet).
Comment on lines
262
to
277
| [ | ||
| name: 'Danilo Di Leo', | ||
| affiliation: '', | ||
| email: '', | ||
| github: '', | ||
| contribution: [], // List of contribution types ('author', 'maintainer' or 'contributor') | ||
| orcid: '' | ||
| ], | ||
| [ | ||
| name: ' Emelie Nilsson and Daniel Lundin', | ||
| affiliation: '', | ||
| email: '', | ||
| github: '', | ||
| contribution: [], // List of contribution types ('author', 'maintainer' or 'contributor') | ||
| orcid: '' | ||
| ], |
Member
There was a problem hiding this comment.
Should be updated. My block:
[
name: 'Daniel Lundin',
affiliation: 'Linnaeus University, Kalmar, Sweden',
email: '[email protected]',
github: '@erikrikarddaniel',
contribution: [ 'author', 'maintainer' ],
orcid: 'https://orcid.org/0000-0002-8779-6464'
]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).No modules updates, I will wait after this PR is merged.