Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@nvnieuwk
Copy link
Contributor

This PR updates the JSON schema to be more complete

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.0.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@nvnieuwk
Copy link
Contributor Author

@FriederikeHanssen failing tests don't seem to be related to anything validation. How do you want me to proceed here?

@FriederikeHanssen
Copy link
Contributor

@maxulysse looks like the same issue as the #1835 ? Shall we merge that one, update this one to make the tests pass?

@maxulysse
Copy link
Member

@maxulysse looks like the same issue as the #1835 ? Shall we merge that one, update this one to make the tests pass?

Sounds like a me plan to me

@maxulysse
Copy link
Member

@nvnieuwk can you sync your branch?

@jen-reeve jen-reeve linked an issue Mar 25, 2025 that may be closed by this pull request
@nvnieuwk
Copy link
Contributor Author

Branch has been synced :)

maxulysse
maxulysse previously approved these changes Mar 25, 2025
@FriederikeHanssen
Copy link
Contributor

The following invalid input values have been detected:, , * --input (/home/runner/work/sarek/sarek/tests/csv/3.0/sample_with_space.csv): Validation of file failed:, \t-> Entry 2: Error for field \'sample\' (test 2): "test 2" does not match regular expression [^\\S+$] (Sample ID must be provided, cannot contain spaces and must be a string value),

😞

@nvnieuwk
Copy link
Contributor Author

The following invalid input values have been detected:, , * --input (/home/runner/work/sarek/sarek/tests/csv/3.0/sample_with_space.csv): Validation of file failed:, \t-> Entry 2: Error for field \'sample\' (test 2): "test 2" does not match regular expression [^\\S+$] (Sample ID must be provided, cannot contain spaces and must be a string value),

😞

yes that one should be fixed now 😁

@nvnieuwk nvnieuwk enabled auto-merge March 25, 2025 08:57
@nvnieuwk
Copy link
Contributor Author

Something seems wrong with the confirm-pass action... 😢

@FriederikeHanssen FriederikeHanssen merged commit 7bbacf7 into nf-core:dev Mar 25, 2025
26 checks passed
@FriederikeHanssen
Copy link
Contributor

Something seems wrong with the confirm-pass action... 😢

I hadn't approved yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSON schema: Sarek

4 participants