-
Notifications
You must be signed in to change notification settings - Fork 498
Json schema improvements #1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json schema improvements #1842
Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
FriederikeHanssen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
@FriederikeHanssen failing tests don't seem to be related to anything validation. How do you want me to proceed here? |
|
@maxulysse looks like the same issue as the #1835 ? Shall we merge that one, update this one to make the tests pass? |
Sounds like a me plan to me |
|
@nvnieuwk can you sync your branch? |
|
Branch has been synced :) |
😞 |
yes that one should be fixed now 😁 |
|
Something seems wrong with the |
I hadn't approved yet |
This PR updates the JSON schema to be more complete