Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tanyasarkjain
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/pacvar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

@vagkaratzas vagkaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments/suggestions

include { PBSV_DISCOVER } from '../../../modules/nf-core/pbsv/discover/main'
include { PBSV_CALL } from '../../../modules/nf-core/pbsv/call/main'
include { BCFTOOLS_INDEX } from '../../../modules/nf-core/bcftools/index/main'
include { BCFTOOLS_INDEX as BCFTOOLS_INDEX_SV } from '../../../modules/nf-core/bcftools/index/main'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a module is only called once within the same subworkflow, you don't have to rename it. You can select it in the modules.config file with a less generic selector like this:

withName: '.*:BAM_SV_VARIANT_CALLING:BCFTOOLS_INDEX' {
    ext.prefix = { "${meta.id}.pbsv" }
}

ext.prefix = {"${meta.id}.pbsv"}
}
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the prefixes are changing, I guess the generated files will also change names. Be sure to also update the output files in the output.md doc.

Copy link

@vagkaratzas vagkaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tanyasarkjain tanyasarkjain merged commit 012a880 into nf-core:dev Feb 24, 2025
7 checks passed
@tanyasarkjain tanyasarkjain mentioned this pull request Feb 25, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants