-
Notifications
You must be signed in to change notification settings - Fork 9
Changing the names of the pbsv output #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two comments/suggestions
| include { PBSV_DISCOVER } from '../../../modules/nf-core/pbsv/discover/main' | ||
| include { PBSV_CALL } from '../../../modules/nf-core/pbsv/call/main' | ||
| include { BCFTOOLS_INDEX } from '../../../modules/nf-core/bcftools/index/main' | ||
| include { BCFTOOLS_INDEX as BCFTOOLS_INDEX_SV } from '../../../modules/nf-core/bcftools/index/main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a module is only called once within the same subworkflow, you don't have to rename it. You can select it in the modules.config file with a less generic selector like this:
withName: '.*:BAM_SV_VARIANT_CALLING:BCFTOOLS_INDEX' {
ext.prefix = { "${meta.id}.pbsv" }
}
| ext.prefix = {"${meta.id}.pbsv"} | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the prefixes are changing, I guess the generated files will also change names. Be sure to also update the output files in the output.md doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).