Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update all modules #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxulysse merged 4 commits into from
Nov 3, 2023
Merged

update all modules #109

maxulysse merged 4 commits into from
Nov 3, 2023

Conversation

@maxulysse
Copy link
Member

@maxulysse maxulysse commented Nov 3, 2023

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/rnavar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Nov 3, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 80c6c5b

+| ✅ 159 tests passed       |+
!| ❗   4 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowRnavar.groovy: Optionally add in-text citation tools to this list.

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-11-03 14:00:45

FriederikeHanssen
FriederikeHanssen reviewed Nov 3, 2023
View reviewed changes
modules/nf-core/custom/dumpsoftwareversions/environment.yml Outdated
- bioconda
- defaults
dependencies:
- bioconda::multiqc=1.15
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen Nov 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the record: issue already open to update

FriederikeHanssen
FriederikeHanssen requested changes Nov 3, 2023
View reviewed changes
@maxulysse
Copy link
Member Author

maxulysse commented Nov 3, 2023

CHANGELOG updated

@FriederikeHanssen FriederikeHanssen self-requested a review November 3, 2023 13:46
@maxulysse maxulysse merged commit dab75ac into nf-core:dev Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxulysse @FriederikeHanssen