Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ch_fasta_fai and ch_gtf fix after nf-core/tools v2.14.1 merge #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxulysse merged 2 commits into from
Jun 27, 2024
Merged

ch_fasta_fai and ch_gtf fix after nf-core/tools v2.14.1 merge #149

maxulysse merged 2 commits into from
Jun 27, 2024

Conversation

@nschcolnicov
Copy link
Contributor

@nschcolnicov nschcolnicov commented Jun 26, 2024 •
edited
Loading

This PR addresses this issue: #148

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/rnavar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Jun 26, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ccd9d82

+| ✅ 213 tests passed       |+
!| ❗   3 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-26 22:02:36

@nschcolnicov nschcolnicov changed the title Dev ch_fasta_fai and ch_gtf fix after nf-core/tools v2.14.1 merge Jun 27, 2024
@maxulysse maxulysse merged commit e563727 into nf-core:dev Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nschcolnicov @maxulysse