Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@SarahMaman
Copy link

@SarahMaman SarahMaman commented Dec 1, 2022

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/rnavar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @SarahMaman,

It looks like this pull-request is has been made against the SarahMaman/rnavar master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the SarahMaman/rnavar dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@maxulysse maxulysse changed the base branch from master to dev December 1, 2022 13:30
@maxulysse
Copy link
Member

Hi @SarahMaman I change the base from master to dev.
Thanks for adding this.
I was hoping to find some time to work on this, but you were more efficient

@SarahMaman
Copy link
Author

Change the target branch to dev

@maxulysse
Copy link
Member

@nf-core-bot fix linting pretty please 🙏

remove trailing spaces
@maxulysse
Copy link
Member

we'll need to fix nf-core linting, but it can be done in a separate PR, we're due for some TEMPLATE sync anyway

@maxulysse maxulysse merged commit 104c049 into nf-core:dev Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants