Thanks to visit codestin.com
Credit goes to github.com

Skip to content

adds channels to meme mt align #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2024
Merged

adds channels to meme mt align #582

merged 1 commit into from
Jul 4, 2024

Conversation

@jemten
Copy link
Collaborator

@jemten jemten commented Jul 4, 2024

The MT alignment with bwa meme lacked the newly introduced channels val_mbuffer_mem and val_sort_threads.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jemten jemten marked this pull request as ready for review July 4, 2024 10:09
@github-actions
Copy link

github-actions bot commented Jul 4, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit ae446ec

+| ✅ 185 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in awsfulltest.yml: You can customise AWS full pipeline tests as required

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-raredisease_logo_dark.png
  • modules_config - modules_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-04 10:09:09

ramprasadn
ramprasadn approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@ramprasadn ramprasadn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jemten jemten merged commit af42f38 into dev Jul 4, 2024
@jemten jemten deleted the fix_mt_meme branch July 4, 2024 11:31
@ramprasadn ramprasadn restored the fix_mt_meme branch July 4, 2024 11:52
@ramprasadn ramprasadn deleted the fix_mt_meme branch July 4, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ramprasadn ramprasadn ramprasadn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jemten @ramprasadn