Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kubranarci
Copy link
Contributor

I have a PR allowing users to start from BAM files. Seems to be working. I also have bam files (which is in this repo for now) to be added to test-datasets generated from test case.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@kubranarci kubranarci changed the base branch from master to dev February 27, 2025 12:20
@kubranarci kubranarci requested a review from maxulysse February 27, 2025 12:20
@nf-core nf-core deleted a comment from github-actions bot Feb 27, 2025
@maxulysse
Copy link
Member

Interesting.
Can you add some tests for this?

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I do recommend thinking about switching to nf-test for better testing.

@ramprasadn
Copy link
Collaborator

Thanks for the review @maxulysse!

nf-test tests are in the pipeline.

@ramprasadn ramprasadn merged commit b0ab616 into nf-core:dev Mar 17, 2025
10 checks passed
@kubranarci
Copy link
Contributor Author

Thanks for making this possible @maxulysse @ramprasadn :) Looking forward to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants