Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Go bug hunting for prettier pre-commit #2097

@ewels

Description

@ewels

Need to be super sure that the new pre-commit prettier stuff isn't going to blow up in our faces when we release. Related to a bit of a concerning thread on Slack. Things to check:

  • Works when installing directly with pip and not cloning the repo
    • Could be that only the nf_core directory is copied, despite MANIFEST.in and so the pre-commit config cannot be found
  • Works without doing any pre-commit install steps first

Might be worth including a pre-commit config file in the template for the root of the pipeline repo. If we do so then need to check:

  • Works without pre-commit install, as we don't want to silently change people's git commit workflows

I think it would be good to test by using a blank GitPod instance or something, basically an empty machine. Then installing tools via pip and creating a new repo and seeing if stuff works as expected.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions