-
Notifications
You must be signed in to change notification settings - Fork 223
Closed
Labels
Milestone
Description
Need to be super sure that the new pre-commit prettier stuff isn't going to blow up in our faces when we release. Related to a bit of a concerning thread on Slack. Things to check:
- Works when installing directly with
pipand not cloning the repo- Could be that only the
nf_coredirectory is copied, despiteMANIFEST.inand so the pre-commit config cannot be found
- Could be that only the
- Works without doing any
pre-commit installsteps first
Might be worth including a pre-commit config file in the template for the root of the pipeline repo. If we do so then need to check:
- Works without
pre-commit install, as we don't want to silently change people'sgit commitworkflows
I think it would be good to test by using a blank GitPod instance or something, basically an empty machine. Then installing tools via pip and creating a new repo and seeing if stuff works as expected.