Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecated .nf-core-lint.yaml still used by nf-core modules lint #2212

@keysmashes

Description

@keysmashes

Description of the bug

def load_lint_config(self):
"""Parse a pipeline lint config file.
Look for a file called either `.nf-core-lint.yml` or
`.nf-core-lint.yaml` in the pipeline root directory and parse it.
(`.yml` takes precedence).
Add parsed config to the `self.lint_config` class attribute.
"""

called here (and only here):

def set_up_pipeline_files(self):
self.load_lint_config()

which is reached when repo_type is "pipeline" (as determined by utils.load_tools_config, which loads .nf-core.yaml and emits a warning if .nf-core-lint.yaml is present)

I didn't get time at today's hackathon to determine the real-world impact of this (just filing this issue to make sure I don't forget about it by tomorrow...), but I think the solution will be to make ComponentCommand.load_lint_config use utils.load_tools_config (or just replace the call to ComponentCommand.load_lint_config with a call to utils.load_tools_config, if the former really definitely is only used in ModuleLint)

also, there's a docstring here that still mentions the deprecated filename:

You can ignore tests using a file called [blue].nf-core-lint.yaml[/] [i](if you have a good reason!)[/].

Command used and terminal output

No response

System information

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions