Conversation
… reference text construction
…ce validation (as now done by nf-schema)
… existance validation (as now done by nf-schema)" This reverts commit 5bf0cd4. :wq
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Bump post-release
Update DIAMOND_BLASTX for syntax fixes
…ialisation subworkflow
|
We are stuck on a bug in taxpasta related to dependencies, so we will need to fix taxpasta (or rather the conda recipe) before we can release with full conda support.. |
Improve bioflow-insights compatibility
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.4.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
rannick
left a comment
There was a problem hiding this comment.
Small comment, otherwise it looks good to me, nice work!
| * @return A channel with one element per reference database. Each element is a | ||
| * pair of a meta map with an `id` key and all corresponding profiles. | ||
| */ | ||
| def groupProfiles(ch_profiles, groupTupleOptions = [:]) { |
There was a problem hiding this comment.
Isn't this defined twice? Would it make sense to group?
There was a problem hiding this comment.
I am not sure I follow what you mean by grouping.
Important! Template update for nf-core/tools v3.5.1
main.nf
Outdated
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| THE END | ||
| GENOME PARAMETER VALUES | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| */ |
There was a problem hiding this comment.
I think you can delete this section if you have no GENOME PARAMETERS.
but non blocking obviously
Apply review suggestions
jfy133
left a comment
There was a problem hiding this comment.
I don't see anything jumping out at me
|
|
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).