Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sofia-angeli
Copy link

No description provided.

@dalito
Copy link
Member

dalito commented Apr 14, 2025

Good morning, Sofia!

The pipeline looks for the voc4cat.xlsx file only in the folder /inbox-excel-vocabs but you dropped it into the root directory. You can just move it to /inbox-excel-vocabs and commit the change. Be sure to edit your PR branch.

Could you maybe change the title of the PR to something more meaningful (e.g. "Add concepts for kinetic modelling") and provide a short description of the addition?

@sofia-angeli sofia-angeli changed the title contribution to voc4cat addition of kinetic simulation related parameters and catalytic properties Apr 14, 2025
@github-project-automation github-project-automation bot moved this from New to Completed in Voc4Cat cross-repo view Apr 14, 2025
@sofia-angeli sofia-angeli reopened this Apr 14, 2025
@github-project-automation github-project-automation bot moved this from Completed to New in Voc4Cat cross-repo view Apr 14, 2025
@dalito
Copy link
Member

dalito commented Apr 14, 2025

This looks good now! No need to close/re-open. ...or are you trying to achieve something special?

@sofia-angeli
Copy link
Author

sofia-angeli commented Apr 14, 2025

Good morning David!
I am new to github, so that explains my actions. I couldn't find the way to update the pull request after the changes I made in my branch or create a new one, so I closed it and reopened. Obviously not necessary. 😊

@dalito
Copy link
Member

dalito commented Apr 14, 2025

This pull request is still only a branch in your forked repository (it was not copied or send to voc4cat by making the pull request). So when you commit changes to the branch "voc4Cat_SA1" in your fork, this pull request shows the changes automatically here (because it is the same).
Only when the pull request is merged, your code becomes part of of voc4cat.

The distributed nature of git with many new terms can be overwhelming at the beginning. If you have questions, just ask.

@dalito dalito moved this from New to To Do (<2 weeks) in Voc4Cat cross-repo view Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Do (<2 weeks)

Development

Successfully merging this pull request may close these issues.

2 participants