-
Notifications
You must be signed in to change notification settings - Fork 29
fix: refactor and fix favicon.js #64
Conversation
To avoid repeting common parts.
The collapse plugin must be imported first so I've adjusted base.html to fix this
|
Hi @ar4s! Thanks for working on this. I was looking through the code and attempting to understand the changes, I have a few questions.
I've also not used the django templating much, and think that that your method of using different blocks and I made a few formatting changes (I'm a stubborn 4 tabs for indents user lol) and the alpine.js collapse plugin needs to be imported second, so I rearranged a few things in |
Yes, exactly so you don't need repeat same chunks of code over and over again in views.
It is exposed in
My bad - I fixed that in c12f4a0
In this case I want to generate JS file on the fly to provide some dynamic information to present how you can pass information from backend to frontend. You can use also JSON or JSONP but i think for that scale it is enough and straightforward.
I appreciate that because I am new in the project and I don't know how to test properly whole application. |
It should be the light icon in dark mode and vice versa
Got it, thank you for answering my questions
That makes sense, it's a good new method I've not used before, I'll have to keep that in mind for future
I have instructions in the In any case this issue has now been completed, I'll get it all merged, thank you! |
Installation is straigtforward because it is a simple Django project :) |
@nfoert I know that PR is quite large but if have any question feel free to ask.
Resolves #20