Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(logger-plugin): run filter function in injection context #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(logger-plugin): run filter function in injection context #2236

merged 1 commit into from
Oct 21, 2024

Conversation

@arturovt
Copy link
Member

@arturovt arturovt commented Oct 21, 2024 •
edited
Loading

In this commit, we wrap the options.filter function for the logger plugin to run within
the injection context, allowing the retrieval of any injectees that may have properties
required for filtering. For example, the user may want to skip logging actions until the
app's bootstrap is complete.

Additionally, the isIE check has been removed from the log writer, as Internet Explorer
is no longer supported by Angular.

@nx-cloud
Copy link

nx-cloud bot commented Oct 21, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 95eed69. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 21, 2024 •
edited
Loading

Open in Stackblitz

@ngxs/devtools-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/form-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/hmr-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/router-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/storage-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/websocket-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/store

yarn add https://pkg.pr.new/@ngxs/[email protected]

commit: 95eed69

@arturovt arturovt force-pushed the fix/logger-plugin-inject branch from b64ce88 to 21b1af6 Compare October 21, 2024 12:48
@arturovt
fix(logger-plugin): run filter function in injection context
95eed69 
In this commit, we wrap the `options.filter` function for the logger plugin to run within
the injection context, allowing the retrieval of any injectees that may have properties
required for filtering. For example, the user may want to skip logging actions until the
app's bootstrap is complete.

Additionally, the `isIE` check has been removed from the log writer, as Internet Explorer
is no longer supported by Angular.
@arturovt arturovt force-pushed the fix/logger-plugin-inject branch from 21b1af6 to 95eed69 Compare October 21, 2024 12:49
@bundlemon
Copy link

bundlemon bot commented Oct 21, 2024 •
edited
Loading

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 100.32KB 101KB / +0.5%
✅ fesm2022/ngxs-store-internals.mjs
 11.64KB 13KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 6.83KB 7KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.22KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.04KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 1.4KB 2KB / +0.5%

No change in files bundle size

Unchanged groups (2)
Status Path Size Limits
✅ @ngxs/store(esm2022)[gzip]
./esm2022/**/*.mjs
 222.49KB +1%
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 30.74KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Oct 21, 2024 •
edited
Loading

BundleMon (NGXS Plugins)

Files updated (1)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB (-59B -2.75%) +0.5%
Unchanged files (8)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 4.15KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 3.2KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.64KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.61KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.59KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 875B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 411B +0.5%

Total files change -59B -0.28%

Groups updated (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.71KB (-59B -0.28%) +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Oct 21, 2024 •
edited
Loading

BundleMon (Integration Projects)

Files updated (2)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
 71.77KB (-65B -0.09%) +1%
✅ Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
 68.63KB (-96B -0.14%) +1%
Unchanged files (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
 67.75KB +1%

Total files change -171B -0.08%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 95eed69 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (0.1% change).

View more on Code Climate.

@arturovt arturovt marked this pull request as ready for review October 21, 2024 12:55
markwhitfeld
markwhitfeld approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@markwhitfeld markwhitfeld merged commit 93a8f97 into master Oct 21, 2024
18 checks passed
@markwhitfeld markwhitfeld deleted the fix/logger-plugin-inject branch October 21, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturovt @markwhitfeld