refactor: use field initializers for injectees #2258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we remove constructor parameters to ensure compatibility with the `useDefineForClassFields` compiler option. When public class fields are enabled, such cases throw a `TS2729: Property used before its initialization` error. This occurs when a property (e.g., an injectee) is referenced before the constructor is executed. Additionally, we are removing property decorators such as `@Inject` with this change. Property decorators are not permitted when experimental decorators are disabled. This adjustment helps make the framework compatible with these TypeScript compiler options moving forward.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 67204a8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
|
commit: |
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Unchanged files (9)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Unchanged files (3)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit fac2e57 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
|
im on v19 and if I have useDefineForClassFields: true, I still get the "TS2729: Property store is used before its initialization." error. If I set it back to false, it worksa as intended was this commit addressing that isuse? this is my tsconfig for reference /* To learn more about Typescript configuration file: https://www.typescriptlang.org/docs/handbook/tsconfig-json.html. */
/* To learn more about Angular compiler options: https://angular.dev/reference/configs/angular-compiler-options. */
{
"compileOnSave": false,
"compilerOptions": {
"outDir": "./dist/out-tsc",
"strict": true,
"noImplicitOverride": true,
"strictPropertyInitialization": false,
"noPropertyAccessFromIndexSignature": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"skipLibCheck": true,
"esModuleInterop": true,
"sourceMap": true,
"declaration": false,
"experimentalDecorators": true,
"useDefineForClassFields": true,
"moduleResolution": "bundler",
"importHelpers": true,
"target": "ES2022",
"module": "ES2022",
"lib": ["ES2022", "dom"],
"paths": {
"@ng-bootstrap/ng-bootstrap": ["../dist/ng-bootstrap"]
}
},
"angularCompilerOptions": {
"enableI18nLegacyMessageIdFormat": false,
"strictInjectionParameters": true,
"strictInputAccessModifiers": true,
"strictTemplates": true
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we remove constructor parameters to ensure compatibility with the
useDefineForClassFieldscompiler option. When public class fields are enabled, such cases throw aTS2729: Property used before its initializationerror. This occurs when a property (e.g., an injectee) is referenced before the constructor is executed.Additionally, we are removing property decorators such as
@Injectwith this change. Property decorators are not permitted when experimental decorators are disabled. This adjustment helps make the framework compatible with these TypeScript compiler options moving forward.