refactor: allow tree-shaking of dev-only code #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we're removing all const `NG_DEV_MODE` declarations and inlining
`typeof ngDevMode !== 'undefined' && ngDevMode` conditions.
This change is **required** for ESBuild tree-shaking to work properly.
It has been observed that development-only code is not being dropped in production builds.
For example, this code:
```js
const NG_DEV_MODE = typeof ngDevMode !== 'undefined' && ngDevMode;
if (NG_DEV_MODE) {
ensureStateNameIsValid(stateName);
}
```
Becomes the following after the build:
```js
var NG_DEV_MODE$4 = !1;
NG_DEV_MODE$4 && ensureStateNameIsValid(stateName);
```
Terser was able to inline `NG_DEV_MODE` variables, because it was able to evaluate their
expressions during the build (that it's _falsy_) and remove them entirely.
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0dd8a74. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
BundleMonFiles updated (3)
Unchanged files (3)
Total files change -145B -0.11% Groups updated (2)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (4)
Unchanged files (5)
Total files change -77B -0.37% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
|
Code Climate has analyzed commit 0dd8a74 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 92.8% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.3% (0.0% change). View more on Code Climate. |
BundleMon (Integration Projects)Files updated (3)
Total files change -1.6KB -0.77% Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we're removing all const
NG_DEV_MODEdeclarations and inliningtypeof ngDevMode !== 'undefined' && ngDevModeconditions.This change is required for ESBuild tree-shaking to work properly. It has been observed that development-only code is not being dropped in production builds.
For example, this code:
Becomes the following after the build:
Terser was able to inline
NG_DEV_MODEvariables, because it was able to evaluate their expressions during the build (that it's falsy) and remove them entirely.