Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(store): tree-shake development options token #2260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturovt merged 1 commit into from
Nov 18, 2024
Merged

refactor(store): tree-shake development options token #2260

arturovt merged 1 commit into from
Nov 18, 2024

Conversation

@arturovt
Copy link
Member

@arturovt arturovt commented Nov 18, 2024

Adds __PURE__ annotation to the NGXS_DEVELOPMENT_OPTIONS to drop the code when it's unused in production.

@arturovt
refactor(store): tree-shake development options token
ab9cc5e 
Adds `__PURE__` annotation to the `NGXS_DEVELOPMENT_OPTIONS` to drop the code when it's
unused in production.
@nx-cloud
Copy link

nx-cloud bot commented Nov 18, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ab9cc5e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 18, 2024

Open in Stackblitz

@ngxs/devtools-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/form-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/hmr-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/storage-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/router-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/store

yarn add https://pkg.pr.new/@ngxs/[email protected]

@ngxs/websocket-plugin

yarn add https://pkg.pr.new/@ngxs/[email protected]

commit: ab9cc5e

@arturovt arturovt marked this pull request as ready for review November 18, 2024 18:43
@arturovt arturovt merged commit a6757af into master Nov 18, 2024
@arturovt arturovt deleted the refactor/dev-options_drop branch November 18, 2024 18:43
@bundlemon
Copy link

bundlemon bot commented Nov 18, 2024

BundleMon

Files updated (1)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 100.78KB (+17B +0.02%) 103KB / +0.5%
Unchanged files (5)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals.mjs
 11.29KB 13KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 6.83KB 7KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.22KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 1.4KB 2KB / +0.5%

Total files change +17B +0.01%

Groups updated (2)
Status Path Size Limits
✅ @ngxs/store(esm2022)[gzip]
./esm2022/**/*.mjs
 223.46KB (+41B +0.02%) +1%
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 30.74KB (+19B +0.06%) +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Nov 18, 2024

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 4.06KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 3.01KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.61KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.57KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.52KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.17KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 861B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 396B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.2KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Nov 18, 2024

BundleMon (Integration Projects)

Files updated (3)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
 67.29KB (-17B -0.02%) +1%
✅ Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
 68.25KB (-20B -0.03%) +1%
✅ Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
 70.08KB (-21B -0.03%) +1%

Total files change -58B -0.03%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arturovt