Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(store): pull less RxJS symbols #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

refactor(store): pull less RxJS symbols #2310

merged 1 commit into from
Mar 10, 2025

Conversation

@arturovt
Copy link
Member

@arturovt arturovt commented Mar 10, 2025 •
edited
Loading

In this commit, we import everything from rxjs instead of importing from rxjs/operators.

@arturovt
refactor(store): pull less RxJS symbols
36ea83f 
In this commit, we import everything from `rxjs` instead of importing from `rxjs/operators`.
@arturovt arturovt force-pushed the refactor/pull-less-rxjs_2 branch from bc01ac0 to 36ea83f Compare March 10, 2025 21:46
@nx-cloud
Copy link

nx-cloud bot commented Mar 10, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 36ea83f.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 44s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 2m 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-10 21:53:51 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 10, 2025 •
edited
Loading

Open in Stackblitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2310

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2310

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2310

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2310

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2310

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2310

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2310

commit: 36ea83f

@arturovt arturovt marked this pull request as ready for review March 10, 2025 21:52
@arturovt arturovt merged commit ea51ae4 into master Mar 10, 2025
11 checks passed
@arturovt arturovt deleted the refactor/pull-less-rxjs_2 branch March 10, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arturovt