Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(ci): move to bundlemon v3 #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 15, 2025
Merged

fix(ci): move to bundlemon v3 #2330

merged 11 commits into from
May 15, 2025

Conversation

markwhitfeld
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Bundlemon is currently not running due to a "bad project credentials" error.
This PR moves to use the github action and v2 of the bundlemon api in the hope that this will resolve the issue.

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@nx-cloud
Copy link

nx-cloud bot commented May 14, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit e2f1ccf.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-15 10:46:53 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 14, 2025 •
edited
Loading

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2330

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2330

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2330

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2330

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2330

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2330

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2330

commit: e2f1ccf

@markwhitfeld markwhitfeld changed the title fix(ci): move to bundlemon v2 fix(ci): move to bundlemon v3 May 14, 2025
@markwhitfeld markwhitfeld marked this pull request as draft May 14, 2025 10:14
markwhitfeld and others added 3 commits May 14, 2025 12:19
@markwhitfeld
chore(ci): regenerate yarn.lock file
c4d9c2d
@markwhitfeld
chore(ci): regenerate yarn.lock file again
e0ed38c
@markwhitfeld
chore(integration): fix build issue with integration app
727e244 
The error resolved was:
Error: node_modules/parse5/dist/tokenizer/index.d.ts:3:31 - error TS7016: Could not find a declaration file for module 'entities/decode'. 'C:/dev/personal/ngxs/node_modules/parse5/node_modules/entities/decode.js' implicitly has an 'any' type.
        Try `npm i --save-dev @types/entities` if it exists or add a new declaration (.d.ts) file containing `declare module 'entities/decode';`
      3 import { EntityDecoder } from 'entities/decode';
@bundlemon
Copy link

bundlemon bot commented May 14, 2025 •
edited
Loading

BundleMon

Files updated (4)
Status Path Size Limits
❌ fesm2022/ngxs-store-internals-testing.mjs
 10.52KB (+3.72KB +54.66%) 13KB / +0.5%
❌ fesm2022/ngxs-store-internals.mjs
 13.78KB (+1.96KB +16.57%) 15KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB (-173B -2.72%) 7KB / +0.5%
✅ fesm2022/ngxs-store.mjs
 100.52KB (-4.91KB -4.66%) 105KB / +0.5%
Unchanged files (2)
Status Path Size Limits
✅ fesm2022/ngxs-store-plugins.mjs
 2.38KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change +610B +0.45%

Groups updated (1)
Status Path Size Limits
❌ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 32.58KB (+522B +1.59%) +1%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented May 14, 2025 •
edited
Loading

BundleMon (NGXS Plugins)

Files updated (2)
Status Path Size Limits
❌ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 872B (+11B +1.28%) +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.95KB (-28B -0.69%) +0.5%
Unchanged files (7)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.96KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.63KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.56KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.46KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.14KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.01KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 396B +0.5%

Total files change -22B -0.11%

Groups updated (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 19.94KB (-22B -0.11%) +0.5%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented May 14, 2025 •
edited
Loading

BundleMon (Integration Projects)

Files added (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
 +66.15KB +1%
Files removed (3)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng18/dist-integration/browser/mai
n-(hash).js
 -70.1KB +1%
✅ Main bundles(Gzip)
hello-world-ng17/dist-integration/main.(hash)
.js
 -68.24KB +1%
✅ Main bundles(Gzip)
hello-world-ng16/dist-integration/main.(hash)
.js
 -67.3KB +1%

Total files change -139.49KB -67.83%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@markwhitfeld
Copy link
Member Author

This PR is on hold until the maintainer of Bundlemon reconnects our project history to the v2 connected project.

@markwhitfeld markwhitfeld marked this pull request as ready for review May 15, 2025 10:42
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit e2f1ccf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.0% (0.0% change).

View more on Code Climate.

@markwhitfeld markwhitfeld merged commit 179a5bb into master May 15, 2025
15 checks passed
@markwhitfeld markwhitfeld deleted the fix-move-to-bundlemon-v2 branch May 15, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arturovt arturovt arturovt approved these changes

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markwhitfeld @arturovt