Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: replace const enum #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2025
Merged

refactor: replace const enum #2332

merged 2 commits into from
May 28, 2025

Conversation

arturovt
Copy link
Member

@arturovt arturovt commented May 28, 2025 •
edited by markwhitfeld
Loading

Angular has a local compilation mode, intended for use with the TypeScript compiler option isolatedModules, which disallows importing const enum. In such cases, we replace it with a const object.

An enum generates more code compared to a plain object.

Resolves issue #2331

@nx-cloud
Copy link

nx-cloud bot commented May 28, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 0654555.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx run-many --target=build --all ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-28 16:22:58 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 28, 2025 •
edited
Loading

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2332

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2332

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2332

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2332

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2332

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2332

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2332

commit: 0654555

@bundlemon
Copy link

bundlemon bot commented May 28, 2025 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.47KB (-57B -0.53%) 13KB / +0.5%
✅ fesm2022/ngxs-store.mjs
 100.37KB (-151B -0.15%) 105KB / +0.5%
Unchanged files (4)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals.mjs
 13.78KB 15KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.38KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change -208B -0.15%

Groups updated (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 32.54KB (-48B -0.14%) +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented May 28, 2025 •
edited
Loading

BundleMon (NGXS Plugins)

Files updated (2)
Status Path Size Limits
❌ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 911B (+39B +4.47%) +0.5%
❌ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 419B (+23B +5.81%) +0.5%
Unchanged files (7)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.95KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.96KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.63KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.56KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.46KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.14KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.01KB +0.5%

Total files change +70B +0.34%

Groups updated (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.01KB (+70B +0.34%) +0.5%

Final result: ❌

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented May 28, 2025 •
edited
Loading

BundleMon (Integration Projects)

Files updated (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
 66.24KB (+94B +0.14%) +1%

Total files change +94B +0.14%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt
refactor: replace const enum
d8343f8 
Angular has a local compilation mode, intended for use with the TypeScript compiler
option `isolatedModules`, which disallows importing `const enum`. In such cases,
we replace it with a `const` object.
@arturovt arturovt force-pushed the refactor/replace-const-enum branch from b3613e7 to d8343f8 Compare May 28, 2025 16:18
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 0654555 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.0% (0.0% change).

View more on Code Climate.

@arturovt arturovt marked this pull request as ready for review May 28, 2025 22:27
@arturovt arturovt merged commit 6b0346e into master May 28, 2025
14 of 15 checks passed
@arturovt arturovt deleted the refactor/replace-const-enum branch May 28, 2025 22:27
@markwhitfeld markwhitfeld linked an issue Jun 5, 2025 that may be closed by this pull request
🐞[BUG]: const enum in @ngxs/storage-plugin causes TS2748 when using isolatedModules: true #2331
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐞[BUG]: const enum in @ngxs/storage-plugin causes TS2748 when using isolatedModules: true

1 participant

@arturovt