Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(store): add missing detach to action director #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix(store): add missing detach to action director #2349

merged 2 commits into from
Jun 18, 2025

Conversation

arturovt
Copy link
Member

That change has been lost in commits in the ActionDirector PR.

@arturovt
fix(store): add missing detach to action director
3984e88 
That change has been lost in commits in the `ActionDirector` PR.
@nx-cloud
Copy link

nx-cloud bot commented Jun 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 254ecf8.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 16s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 23s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-18 15:04:19 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 18, 2025 •
edited
Loading

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2349

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2349

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2349

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2349

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2349

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2349

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2349

commit: 254ecf8

@bundlemon
Copy link

bundlemon bot commented Jun 18, 2025 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 97.75KB (+42B +0.04%) 105KB / +0.5%
Unchanged files (5)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals.mjs
 13.62KB 15KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.32KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.37KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change +42B +0.03%

Unchanged groups (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 32.06KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jun 18, 2025 •
edited
Loading

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.95KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.93KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.7KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.58KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.47KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 947B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 453B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.25KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jun 18, 2025 •
edited
Loading

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng20/dist-integration/browser/mai
n-(hash).js
 66.97KB +1%

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 254ecf8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 94.0% (0.0% change).

View more on Code Climate.

@arturovt arturovt merged commit 178d0ad into master Jun 18, 2025
15 checks passed
@arturovt arturovt deleted the fix/director branch June 18, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld markwhitfeld approved these changes

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturovt @markwhitfeld