Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(store): remove @Select decorator #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2025
Merged

refactor(store): remove @Select decorator #2341

merged 1 commit into from
Jun 15, 2025

Conversation

arturovt
Copy link
Member

We deprecated this decorator long time ago, it's now time to move forward and remove it completely.

@nx-cloud
Copy link

nx-cloud bot commented Jun 11, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 054e1c5.

Command Status Duration Result
nx run-many --target=test --all --configuration... ✅ Succeeded 2m 14s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 5s View ↗
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=build --all ✅ Succeeded 1m 36s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-11 21:31:48 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 11, 2025 •
edited
Loading

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2341

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2341

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2341

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2341

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2341

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2341

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2341

commit: 054e1c5

@bundlemon
Copy link

bundlemon bot commented Jun 11, 2025 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 97.67KB (-2.88KB -2.87%) 105KB / +0.5%
Unchanged files (5)
Status Path Size Limits
✅ fesm2022/ngxs-store-internals.mjs
 13.78KB 15KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.47KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.38KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

Total files change -2.88KB -2.16%

Groups updated (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 31.91KB (-677B -2.03%) +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jun 11, 2025 •
edited
Loading

BundleMon (NGXS Plugins)

Unchanged files (9)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.95KB +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.96KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.63KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.56KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.46KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.14KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.01KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 955B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 457B +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.09KB +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Jun 11, 2025 •
edited
Loading

BundleMon (Integration Projects)

Files updated (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng19/dist-integration/browser/mai
n-(hash).js
 66.22KB (-67B -0.1%) +1%

Total files change -67B -0.1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt
refactor(store): remove @Select decorator
054e1c5 
We deprecated this decorator long time ago, it's now time to move forward and remove it completely.
@arturovt arturovt force-pushed the refactor/drop-select branch from 283a656 to 054e1c5 Compare June 11, 2025 21:25
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 054e1c5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.9% (0.0% change).

View more on Code Climate.

@arturovt arturovt marked this pull request as ready for review June 15, 2025 11:38
@arturovt arturovt merged commit a6e7caf into master Jun 15, 2025
13 checks passed
@arturovt arturovt deleted the refactor/drop-select branch June 15, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arturovt