Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(storage-plugin): guard against engine may be null #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arturovt merged 2 commits into from
Sep 1, 2025
Merged

fix(storage-plugin): guard against engine may be null #2367

arturovt merged 2 commits into from
Sep 1, 2025
+6 −1

Conversation

@arturovt
Copy link
Member

@arturovt arturovt commented Sep 1, 2025

No description provided.

@nx-cloud
Copy link

nx-cloud bot commented Sep 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 78feb89

Command Status Duration Result
nx lint-types store ✅ Succeeded <1s View ↗
nx run-many --target=test --all --configuration... ✅ Succeeded 2s View ↗
nx run-many --target=lint --all --exclude=creat... ✅ Succeeded 1s View ↗
nx run-many --target=build --all ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-01 20:06:31 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 1, 2025 •
edited
Loading

Open in StackBlitz

@ngxs/devtools-plugin

npm i https://pkg.pr.new/@ngxs/devtools-plugin@2367

@ngxs/form-plugin

npm i https://pkg.pr.new/@ngxs/form-plugin@2367

@ngxs/hmr-plugin

npm i https://pkg.pr.new/@ngxs/hmr-plugin@2367

@ngxs/router-plugin

npm i https://pkg.pr.new/@ngxs/router-plugin@2367

@ngxs/storage-plugin

npm i https://pkg.pr.new/@ngxs/storage-plugin@2367

@ngxs/store

npm i https://pkg.pr.new/@ngxs/store@2367

@ngxs/websocket-plugin

npm i https://pkg.pr.new/@ngxs/websocket-plugin@2367

commit: 78feb89

@bundlemon
Copy link

bundlemon bot commented Sep 1, 2025 •
edited
Loading

BundleMon

Unchanged files (6)
Status Path Size Limits
✅ fesm2022/ngxs-store.mjs
 103.83KB 105KB / +0.5%
✅ fesm2022/ngxs-store-internals.mjs
 13.62KB 15KB / +0.5%
✅ fesm2022/ngxs-store-internals-testing.mjs
 10.32KB 13KB / +0.5%
✅ fesm2022/ngxs-store-operators.mjs
 6.05KB 7KB / +0.5%
✅ fesm2022/ngxs-store-plugins.mjs
 2.37KB 3KB / +0.5%
✅ fesm2022/ngxs-store-experimental.mjs
 574B 2KB / +0.5%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
✅ @ngxs/store(fesm2022)[gzip]
./fesm2022/*.mjs
 33.6KB +1%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Sep 1, 2025 •
edited
Loading

BundleMon (NGXS Plugins)

Files updated (1)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin.m
js
 3.97KB (+15B +0.37%) +0.5%
Unchanged files (8)
Status Path Size Limits
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin.mjs
 2.93KB +0.5%
✅ Plugins(fesm2022)[gzip]
hmr-plugin/fesm2022/ngxs-hmr-plugin.mjs
 2.72KB +0.5%
✅ Plugins(fesm2022)[gzip]
websocket-plugin/fesm2022/ngxs-websocket-plug
in.mjs
 2.58KB +0.5%
✅ Plugins(fesm2022)[gzip]
form-plugin/fesm2022/ngxs-form-plugin.mjs
 2.47KB +0.5%
✅ Plugins(fesm2022)[gzip]
devtools-plugin/fesm2022/ngxs-devtools-plugin
.mjs
 2.23KB +0.5%
✅ Plugins(fesm2022)[gzip]
logger-plugin/fesm2022/ngxs-logger-plugin.mjs
 2.03KB +0.5%
✅ Plugins(fesm2022)[gzip]
storage-plugin/fesm2022/ngxs-storage-plugin-i
nternals.mjs
 947B +0.5%
✅ Plugins(fesm2022)[gzip]
router-plugin/fesm2022/ngxs-router-plugin-int
ernals.mjs
 453B +0.5%

Total files change +15B +0.07%

Groups updated (1)
Status Path Size Limits
✅ All Plugins(fesm2022)[gzip]
./-plugin/fesm2022/.mjs
 20.29KB (+15B +0.07%) +0.5%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@bundlemon
Copy link

bundlemon bot commented Sep 1, 2025 •
edited
Loading

BundleMon (Integration Projects)

Unchanged files (1)
Status Path Size Limits
✅ Main bundles(Gzip)
hello-world-ng20/dist-integration/browser/mai
n-(hash).js
 67.16KB +1%

Total files change +8B +0.01%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@arturovt arturovt marked this pull request as ready for review September 1, 2025 20:26
@arturovt arturovt merged commit 39d8ff1 into master Sep 1, 2025
11 of 13 checks passed
@arturovt arturovt deleted the fix/storage-engine-null branch September 1, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markwhitfeld markwhitfeld Awaiting requested review from markwhitfeld markwhitfeld is a code owner

@kuncevic kuncevic Awaiting requested review from kuncevic kuncevic is a code owner

@Carniatto Carniatto Awaiting requested review from Carniatto Carniatto is a code owner

@poloagustin poloagustin Awaiting requested review from poloagustin poloagustin is a code owner

@joaqcid joaqcid Awaiting requested review from joaqcid joaqcid is a code owner

@splincode splincode Awaiting requested review from splincode splincode is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arturovt