fix(router-plugin): avoid redundant NGXS state updates for identical router snapshots #2372
+39
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…router snapshots Previously, the router plugin always patched NGXS state on every router event, even if the new router snapshot was identical to the current one. This caused unnecessary updates to the internal NGXS state signal, triggering recomputations of `selectSignal` selectors and extra Angular change detection cycles. With this change, we now compare the current and incoming router state (trigger, navigationId, and serialized snapshot). If they are equal, the state update is skipped. This avoids redundant signal emissions, leading to fewer recomputations and improved performance in large apps.
|
View your CI Pipeline Execution ↗ for commit 348f67d
☁️ Nx Cloud last updated this comment at |
@ngxs/devtools-plugin
@ngxs/form-plugin
@ngxs/hmr-plugin
@ngxs/router-plugin
@ngxs/storage-plugin
@ngxs/store
@ngxs/websocket-plugin
commit: |
BundleMonUnchanged files (6)
No change in files bundle size Unchanged groups (1)
Final result: ✅ View report in BundleMon website ➡️ |
BundleMon (NGXS Plugins)Files updated (1)
Unchanged files (8)
Total files change +479B +2.3% Groups updated (1)
Final result: ❌ View report in BundleMon website ➡️ |
BundleMon (Integration Projects)Files updated (1)
Total files change +54B +0.08% Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the router plugin always patched NGXS state on every router event, even if the new router snapshot was identical to the current one. This caused unnecessary updates to the internal NGXS state signal, triggering recomputations of
selectSignalselectors and extra Angular change detection cycles.With this change, we now compare the current and incoming router state (trigger, navigationId, and serialized snapshot). If they are equal, the state update is skipped. This avoids redundant signal emissions, leading to fewer recomputations and improved performance in large apps.