Fix auto reconnect not working #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackia
commented
Mar 27, 2024
|
|
||
| gateway = hass.data[DOMAIN][entry.entry_id] | ||
| gateway.stop() | ||
| await gateway.async_disconnect() |
There was a problem hiding this comment.
cleans up the leftover thread (started by _mqttc.loop_start()) on entry unload.
stackia
commented
Mar 27, 2024
Comment on lines
-73
to
-78
| async def async_stop_mqtt(_event: Event): | ||
| """Stop MQTT component.""" | ||
| await hass.data[DOMAIN][entry.entry_id].async_disconnect() | ||
|
|
||
| hass.bus.async_listen_once(EVENT_HOMEASSISTANT_STOP, async_stop_mqtt) | ||
|
|
There was a problem hiding this comment.
Not necessary here because home assistant calls async_unload_entry when being stopped.
stackia
commented
Mar 27, 2024
| def on_disconnect(self, client, userdata, ret): | ||
| # pylint: disable=unused-argument | ||
| """ on disconnect to mqtt server """ | ||
| self._mqttc.disconnect() |
There was a problem hiding this comment.
Calling _mqttc.disconnect() will cause the mqtt loop thread to exit which breaks the internal reconnecting mechanism of _mqttc.loop_start().
caibinqing
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found the auto reconnect feature is totally broken on my G3. Here is a fix.