Eagerly fill LogFilteredData::filteredItemsCache_#224
Open
gin-ahirsch wants to merge 6 commits intonickbnf:masterfrom
Open
Eagerly fill LogFilteredData::filteredItemsCache_#224gin-ahirsch wants to merge 6 commits intonickbnf:masterfrom
gin-ahirsch wants to merge 6 commits intonickbnf:masterfrom
Conversation
The line numbers will be int::max() if the iterators are at the end, so we don't need to check the iterators here.
534fc4c to
3ed384d
Compare
Contributor
Author
|
I fixed some issues with the last commit. It actually builds now :) |
3ed384d to
4d38f64
Compare
and progressively fill/remove items instead of completely regenerating the whole cache.
by passing in a guess for the index.
4d38f64 to
70538f4
Compare
Contributor
Author
|
Rebased with the following diff: |
caf0e7b to
b49a6a8
Compare
b49a6a8 to
cc302f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.